Skip to content

Allow automation_images updates from any older version#266

Merged
Luap99 merged 1 commit intocontainers:mainfrom
mtrmac:renovate-images
Mar 11, 2026
Merged

Allow automation_images updates from any older version#266
Luap99 merged 1 commit intocontainers:mainfrom
mtrmac:renovate-images

Conversation

@mtrmac
Copy link
Copy Markdown
Collaborator

@mtrmac mtrmac commented Mar 11, 2026

Cause found by Paul.

The easiest way to test this is probably to put it in production…

Comment thread renovate/defaults.json5 Outdated
// Renovate treats "20230120" as the version number, and
// maxMajorIncrement defaults to 500 = 5 months;
// tags with larger difference than that would be ignored.
"maxMajorIncrement": "100000",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs say 0 can be used to disable it. Might as well have it set to zero instead of 10 years which feels less arbitrary to have it set as unlimted.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also renovate faildation fails but does not seem to print an error

renovate-config-validator $CIRRUS_WORKING_DIR/renovate/defaults.json5
[17:02:44.775] INFO (31): Initializing tools all...
[17:02:44.963] INFO (31): Initialize tools all succeded in 187ms.

Looking at https://docs.renovatebot.com/configuration-options/#maxmajorincrement again the value must be an integer not a string I think

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been trying to figure out why renovate-config-validator is never logging anything, but you are right, using an integer here passes.

Cause found by Paul.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac changed the title Allow up to 10 years for automation_images updates Allow automation_images updates from any older version Mar 11, 2026
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 11, 2026

Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's ac738ee6d4c5acf1f5f428dad0e7efbd22a1687a.

@Luap99 Luap99 merged commit 8f941a4 into containers:main Mar 11, 2026
9 checks passed
@mtrmac mtrmac deleted the renovate-images branch March 11, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants