deps: switch away from runc/libct/devices#6809
Merged
Merged
Conversation
The github.com/opencontainers/runc/libcontainer/devices package was _mostly_ moved to github.com/opencontainers/cgroups/devices/config for runc v1.3. In particular, the Device type is now deprecated, and is an alias to cgroups/devices/config.Device). The relevant change was done in commit 9ac03e6 but somehow it missed the define package. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The github.com/opencontainers/runc/libcontainer/devices package was _mostly_ moved to github.com/opencontainers/cgroups/devices/config (see e.g. commit commit 9ac03e6). The rest of runc/libcontainer/devices now lives in moby/sys/devices (see moby/sys#212). The package is deprecated since runc v1.5 and will be removed from runc v1.6. Let's switch now to not worry later. PS vendor/github.com/opencontainers/runc/libcontainer/devices is not removed because it is still being used by common/pkg/parse. This is addressed by containers/container-libs#781 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
dosubot
Bot
added
the
size:XS
nalind
added
the
No New Tests
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
define: switch away from runc/libct/devices
The github.com/opencontainers/runc/libcontainer/devices package was
mostly moved to github.com/opencontainers/cgroups/devices/config
for runc v1.3. In particular, the Device type is now deprecated,
and is an alias to cgroups/devices/config.Device).
The relevant change was done in commit 9ac03e6 but somehow it missed
the define package.
Remove runc/libcontainer/devices dependency
The github.com/opencontainers/runc/libcontainer/devices package was
mostly moved to github.com/opencontainers/cgroups/devices/config
(see e.g. commit commit 9ac03e6).
The rest of runc/libcontainer/devices now lives in moby/sys/devices
(see devices: move libcontainer/devices to moby/sys moby/sys#212). The package is deprecated
since runc v1.5 and will be removed from runc v1.6.
Let's switch now to not worry later.
PS vendor/github.com/opencontainers/runc/libcontainer/devices is not
removed because it is still being used by common/pkg/parse. This is
addressed by common/pkg/parse: switch away from runc/libct/devices container-libs#781
How to verify it
Existing tests should be adequate.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
See also:
Does this PR introduce a user-facing change?