cgroups: provide UserConnection for non-linux platforms#1726
cgroups: provide UserConnection for non-linux platforms#1726openshift-ci[bot] merged 1 commit intocontainers:mainfrom
Conversation
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhatdan ready to ship: containers/podman#20568 passes |
|
LGTM |
edsantiago
left a comment
edsantiago
left a comment
There was a problem hiding this comment.
Oh well, day late dollar short.
|
|
||
| // UserConnection returns an user connection to D-BUS | ||
| func UserConnection(uid int) (*systemdDbus.Conn, error) { | ||
| return nil, fmt.Errorf("systemd d-bus is not supported on this platform") |
There was a problem hiding this comment.
Errorf() could probably just be Error()?
There was a problem hiding this comment.
Shouldn't the linter have blocked this?
| "fmt" | ||
| "os" | ||
|
|
||
| systemdDbus "github.com/coreos/go-systemd/v22/dbus" |
There was a problem hiding this comment.
Does this library compile on non-linux? Is there a way to fake the prototype so it isn't necessary to pull in this package?
There was a problem hiding this comment.
that is a good idea, I'll look into it. For now I've just tried to fix some of the issues I've introduced with #1716 that prevented revendoring into Podman: containers/podman#20568
There is still room for cleanups in the cgroups package.
4 participants
No description provided.