[release-0.52] [crio-1.25] Cherry-pick changes from containers/common/pull#1437#1907
Merged
saschagrunert merged 1 commit intoMar 15, 2024
Conversation
The name is actually a relative path, so rename the field to make it clear add add comments + test to prevent future people from making the same mistake. Regression was caught in podman CI: containers/podman#18350 Fixes d4a3de3 ("Don't call `umask` in subscriptions") Signed-off-by: Paul Holzinger <pholzing@redhat.com>
saschagrunert
approved these changes
Mar 14, 2024
Member
|
@rhatdan we need approval for this one. /lgtm |
mrunalp
approved these changes
Mar 14, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Same here. Merging since tide seems stuck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/assign kwilczynski
What this PR does / why we need it:
Manually cherry-pick changes from #1437 as these changes contain a fix that needs to be backported to CRI-O release 1.25, part of OpenShift 4.12 release.
Related:
umaskin subscriptions #1421Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?