Skip to content

Conversation

@Luap99
Copy link
Member

@Luap99 Luap99 commented Jan 21, 2025

No description provided.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

USe the offical golang goproxy, the fedora package by default uses the
direct mode which pull from the repos directly. However if the
repository is removed or has other errors that will fail while the
goproxy keeps a cache around.

In this particullar case go.opencensus.io has an expired SSL cert and
thus we fail to download it. This becomes an issue in CI as we need to
pull everything to check that vendor tree is clean.

Podman and buildah seems to already set this so we match them with that
change.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@mheon
Copy link
Member

mheon commented Jan 21, 2025

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 34a90af into containers:main Jan 21, 2025
15 checks passed
@Luap99 Luap99 deleted the vendor branch January 21, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants