Switch to opencontainers/cgroups #2345
Conversation
| // Warning: Ensure the "go" and "toolchain" versions match exactly to prevent unwanted auto-updates | ||
|
|
||
| go 1.22.8 | ||
| go 1.23.0 |
There was a problem hiding this comment.
Not sure what your timeline here is but just to be clear:
We are not yet ready to move to go 1.23 as we still use f40 in podman CI. We have planned to switch soon once the f42 beta is out.
There was a problem hiding this comment.
My timeline is runc 1.3 release which is end of April. It looks like it is more or less in line with F42 beta release / F40 EOL.
There was a problem hiding this comment.
We can actually do it earlier, as there's no runc 1.3 dependency
kolyshkin
changed the title
|
Just saw c/storage already updated to Go 1.23 here: containers/storage#2279 |
This is an addition to commit 71117d8 ("Replace golang.org/x/exp/slices with slices from std"). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The new opencontainers/cgroups repo used to be part of runc. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Ah, I see that #2362 cherry-picked Go 1.23 update from there. So, this is no longer a draft. |
kolyshkin
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@kolyshkin This is breaking podman as it still uses the runc types. Can you update podman as well? |
3 participants
Draft until switch to Go 1.23 is possible (podman switching to F41 in CI).High-level overview:
1. Switch to Go 1.23.0 as a minimally required version.2. Use Go 1.24.x for golangci-lint job.3. Switch from golang.org/x/exp/maps to standard library's maps package.Retrospectively, it was a mistake to use x/exp/maps because the API
changed when the package went into std (it now use iter.Seq).
The above is now in #2362.
Switch to opencontainers/cgroups. This used to be part of runc but is living
in a separate repo now.
Fix an outdated ref to slices pkg.