fix(libnetwork): interface name length validation #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheon
reviewed
Mar 19, 2025
libnetwork/internal/util/validate.go
Outdated
| if ifName == "." || ifName == ".." { | ||
| return fmt.Errorf("interface name is . or ..: %w", types.ErrInvalidArg) | ||
| } | ||
| for _, r := range ifName { |
Member
There was a problem hiding this comment.
Use strings.ContainsAny here instead
Member
|
Code LGTM. @Luap99 PTAL. Can we test this in c/common or do we need a Podman test once this vendors? |
Luap99
reviewed
Mar 20, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Please squash the commits and add tests for each error case in libnetwork/netavark/config_test.go
lpcalisi
force-pushed
the
network-interface-validate
branch
2 times, most recently
from
1587d76 to
a9b4f91
Compare
Luap99
reviewed
Mar 20, 2025
Implements interface name length validation during network creation to prevent netlink errors when names exceed the kernel's 15-character limit. This prevents creation of networks with interface names that would cause failures when running containers. Signed-off-by: Lucas Pablo Calisi <lucas.calisi@mercadolibre.com>
lpcalisi
force-pushed
the
network-interface-validate
branch
from
a9b4f91 to
c83bc2b
Compare
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpcalisi, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8077163
into
containers:main
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Linux kernel imposes a 15-character limit on network interface names. Currently,
Podman allows creating networks with interface names longer than this limit, which
leads to runtime failures when attempting to use these networks.
How to reproduce error
For example:
Fix
This change adds validation during network creation by adopting the same approach
used in the CNI project, which already handles this kernel limitation.