Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 20, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/onsi/ginkgo/v2 v2.23.1 -> v2.23.2 age adoption passing confidence

Release Notes

onsi/ginkgo (github.com/onsi/ginkgo/v2)

v2.23.2

Compare Source

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 20, 2025
@rhatdan
Copy link
Member

rhatdan commented Mar 20, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: renovate[bot], rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8f76077 into main Mar 20, 2025
14 of 15 checks passed
@renovate renovate bot deleted the renovate/github.com-onsi-ginkgo-v2-2.x branch March 20, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dependencies Pull requests that update a dependency file lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants