Skip to content

Conversation

@dseomn
Copy link
Contributor

@dseomn dseomn commented Mar 26, 2025

Fixes: containers/podman#25685

* Document that variables can be listed without a value. Experimentally,
  this worked for me, and it's documented in podman's `--env`. I'm
  guessing supporting this in containers.conf too was intentional?
* Document that this config setting is ignored by `podman exec`, see
  containers/podman#25685

Fixes: containers/podman#25685
Signed-off-by: David Mandelberg <david@mandelberg.org>
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the PR. LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2025

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dseomn, Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 720479c into containers:main Mar 27, 2025
13 checks passed
@dseomn dseomn deleted the containers-conf-env branch March 27, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

containers.conf: containers.env doesn't work with podman exec

3 participants