Clarify configuration when using podman machine #2402
Conversation
docs/containers.conf.5.md
Outdated
| Note: If Podman is running in a virtual machine using `podman machine` (this | ||
| includes Mac and Windows hosts), ensure that you add the configuration in the | ||
| virtual machine by using `podman machine ssh`. |
There was a problem hiding this comment.
Note this does not only effect network settings, almost all option from this file must be set server side (in the machine). Notable exceptions are [machine], [farms], [engine.service_destinations], compose_providers, compose_warning_logs, and the remote option and likely more we don't even know about.
So I think this should likely be reworded and put as part of the main description. (Overall we as a team are currently trying to figure out how this whole situation can be improved)
There was a problem hiding this comment.
I'm not sure how to rephrase this to ensure that the information isn't overlooked. My thought was that including such a note directly within the configuration type would make sense.
There was a problem hiding this comment.
How should we move forward with this change?
There was a problem hiding this comment.
Is there any update on this topic? What is preventing us from moving forward with merging this change?
There was a problem hiding this comment.
I don't have a good answer, IMO putting it just under network might also be confusing for others because it affects most options.
There was a problem hiding this comment.
I attempted to relocate the information to a different location within the documentation. What are your thoughts on this approach?
chrw
changed the title
docs/containers.conf.5.md
Outdated
| * `policy.conf` for controlling which images can be pulled to the system. | ||
|
|
||
| Note: If Podman is running in a virtual machine using `podman machine` (this | ||
| includes Mac and Windows hosts), ensure that you edit the configuration files in the |
There was a problem hiding this comment.
Nit: avoid using "you" in man pages. In this case the you brings no value.
ensure that the configuration files are edited in the
|
Thanks, can you please squash your commits into one. |
Signed-off-by: Christian Wolff <christian.wolff@breuninger.de>
|
LGTM as well. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, chrw, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Fixes: containers/podman#25763
Avoid confusion with the
networkconfiguration usingpodman machine.