Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Apr 17, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
golang.org/x/net v0.37.0 -> v0.38.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-22872

The tokenizer incorrectly interprets tags with unquoted attribute values that end with a solidus character (/) as self-closing. When directly using Tokenizer, this can result in such tags incorrectly being marked as self-closing, and when using the Parse functions, this can result in content following such tags as being placed in the wrong scope during DOM construction, but only when tags are in foreign content (e.g. , , etc contexts).


Configuration

📅 Schedule: Branch creation - "" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file security labels Apr 17, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This PR updates the golang.org/x/net module from v0.37.0 to v0.38.0 to address CVE-2025-22872. The go.mod and go.sum files are updated, and the vendored golang.org/x/net files are updated.

Class diagram for HTML Tokenizer (golang.org/x/net/html/token.go) - CVE-2025-22872

classDiagram
    class Tokenizer {
        -data []byte
        -pos int
        -err error
        +Next() TokenType
        +Token() Token
        +parseTag()
        +parseAttributeList()
        +parseData()
    }
    note for Tokenizer "The tokenizer incorrectly interprets tags with unquoted attribute values that end with a solidus character (/) as self-closing."
Loading

File-Level Changes

Change Details Files
Update the golang.org/x/net module to address CVE-2025-22872.
  • Update golang.org/x/net from v0.37.0 to v0.38.0 in go.mod.
  • Update golang.org/x/net in go.sum.
  • Update vendored golang.org/x/net files.
go.mod
go.sum
vendor/golang.org/x/net/html/atom/table.go
vendor/golang.org/x/net/html/parse.go
vendor/golang.org/x/net/html/token.go
vendor/golang.org/x/net/http2/frame.go
vendor/golang.org/x/net/http2/server.go
vendor/modules.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/go-golang.org-x-net-vulnerability branch from d282cdf to d02c2a6 Compare April 21, 2025 12:47
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 37530e5 into main Apr 22, 2025
15 checks passed
@renovate renovate bot deleted the renovate/go-golang.org-x-net-vulnerability branch April 22, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dependencies Pull requests that update a dependency file lgtm security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants