Skip to content

Conversation

@kolyshkin
Copy link
Contributor

This prevents

"defaultErrnoRet": null,

from appearing in seccomp.json, in case DefaultErrnoRet is not set
(if set, this is purely cosmetical).

This member is similar to ErrnoRet in type Syscall,
and should also be marked with omitempty.

Fixes: adee333
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com

Forward ported from #689
Cc; @giuseppe

This prevents

	"defaultErrnoRet": null,

from appearing in seccomp.json.

This member is similar to ErrnoRet in type Syscall,
and should also be marked with omitempty.

Fixes: adee333
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, kolyshkin, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3d7a84b into containers:main Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants