Add defaults for machine-image#411
Merged
Merged
Conversation
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6446 |
Luap99
reviewed
Oct 23, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
The default image should likely be mentioned in common/docs/containers.conf.5.md as well.
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 23, 2025
Fixes: https://issues.redhat.com/browse/RUN-3578 Signed-off-by: Nicola Sella <nsella@redhat.com>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 23, 2025
mtrmac
reviewed
Oct 23, 2025
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Implementation LGTM, I have no opinion on whether this should happen. Trusting the Jira issue existence in that respect.
| CPUs: uint64(cpus), | ||
| DiskSize: 100, | ||
| // TODO: Set machine image default here | ||
| // Currently the default is set in Podman as we need time to stabilize |
Member
There was a problem hiding this comment.
Is the default no longer set in Podman? If it still is, I would not pull this and the next line of comment.
Member
|
One question, |
baude
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/RUN-3578