Revert "cgroup: remove tun/tap from the default allow list"#1637
Merged
giuseppe merged 1 commit intocontainers:mainfrom Jan 13, 2025
Merged
Revert "cgroup: remove tun/tap from the default allow list"#1637giuseppe merged 1 commit intocontainers:mainfrom
giuseppe merged 1 commit intocontainers:mainfrom
Conversation
Member
Author
|
ci failure addressed here: #1638 |
Member
Author
|
@kolyshkin PTAL |
Member
|
/approve |
kolyshkin
approved these changes
Jan 11, 2025
Collaborator
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM.
Apparently
- it is expected that tun/tap is allowed by default;
- some upper-level tools doesn't have easy ways to allow more devices, so they use
--privilegedor the like as an alternative, which is rather bad; - removing tun/tap broke some real runc users.
This reverts commit 1e30424. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
revert-remove-tun-tap
branch
from
d06e428 to
179686b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1e30424.
Copy what runc is already doing here: opencontainers/runc#4555