Skip to content

container: do not write twice the error msg#338

Merged
rhatdan merged 1 commit into
containers:masterfrom
giuseppe:no-write-twice-errors-detach
Apr 18, 2020
Merged

container: do not write twice the error msg#338
rhatdan merged 1 commit into
containers:masterfrom
giuseppe:no-write-twice-errors-detach

Conversation

@giuseppe
Copy link
Copy Markdown
Member

do not write twice the error message when -d is used.

Closes: #335

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

do not write twice the error message when -d is used.

Closes: containers#335

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@kolyshkin
Copy link
Copy Markdown
Collaborator

kolyshkin commented Apr 17, 2020

Tested; the issue appears to be fixed:

[root@localhost tst]# ../crun --systemd-cgroup run -d xxx
2020-04-17T22:53:57.000150192Z: sd-bus call: No such device or address
[root@localhost tst]# ../crun --systemd-cgroup run xxx
2020-04-17T22:55:32.000619115Z: sd-bus call: No such device or address
[root@localhost tst]# 

Copy link
Copy Markdown
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe marked this pull request as draft April 18, 2020 07:56
@giuseppe giuseppe marked this pull request as ready for review April 18, 2020 08:20
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Apr 18, 2020

LGTM

@rhatdan rhatdan merged commit f9be10a into containers:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error message duplication

3 participants