[openSUSE 15.1] Missing libseccomp headers#360
Merged
giuseppe merged 1 commit intoMay 18, 2020
Merged
Conversation
For openSUSE 15.1, `seccomp.h` is located as `/usr/include/libseccomp/seccomp.h` which could be fetched by `pkg-config --libs libseccomp` and `pkg-config --cflags libseccomp`. This patch reference from https://build.opensuse.org/package/view_file/openSUSE:Factory/lxc/configure-find-seccomp-using-pkg-config.patch?rev=45, so inject the `pkg-config` result on-the-fly. Fixes containers#358
Contributor
Author
|
@giuseppe I test this PR with master but actually failed on recent openSUSE 15.1 due to systemd 234 (case similar as #349, which required for systemd >= 237). BTW, manually apply changes into crun 0.13 make it works perfectly as other OS.
|
Member
|
thanks for opening a PR. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For openSUSE 15.1,
seccomp.his located as/usr/include/libseccomp/seccomp.hwhich could be fetched bypkg-config --libs libseccompandpkg-config --cflags libseccomp.This patch reference from https://build.opensuse.org/package/view_file/openSUSE:Factory/lxc/configure-find-seccomp-using-pkg-config.patch?rev=45, so inject the
pkg-configresult on-the-fly.Fixes #358