On exec, honor additional_gids from the process spec#645
Merged
giuseppe merged 1 commit intocontainers:masterfrom Apr 11, 2021
Merged
On exec, honor additional_gids from the process spec#645giuseppe merged 1 commit intocontainers:masterfrom
giuseppe merged 1 commit intocontainers:masterfrom
Conversation
…er definition The code was using the process defined in the container definition to find additional_gids, not the one passed on the command line or created by default. Fixes containers#644 Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
Contributor
Author
|
The test here fails when run rootless - getgroups() returns the nobody group. I'm not quite sure what namespace gyrations would be needed to fix that. |
giuseppe
approved these changes
Apr 11, 2021
Member
giuseppe
left a comment
giuseppe
left a comment
There was a problem hiding this comment.
hi Owen, thanks for the patch!
LGTM
Member
|
new Fedora builds: Fedora 33: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8933e21f9d |
Member
|
Thanks for tracking this down to crun and fixing it, @owtaylor ! |
This was referenced Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was using the process defined in the container definition to find additional_gids,
not the one passed on the command line or created by default.
Fixes #644