container: wrap execv in retry-on-eintr

[kolyshkin]

Apparently, execve(2) can return EINTR on Azure (CIFS share),
which results in sporadic failures in crun exec (and possibly crun run).

To fix, wrap execv in TEMP_FAILURE_RETRY macro.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1917662
See-also: opencontainers/runc#3045

[kolyshkin]

I suspect that exec from CIFS mount [from Azure] is the only case where execve returns EINTR, so this is a not well-known case.

In general, EINTR is not very well documented. For this particular case, is not listed in execve(2) man page as a possible code. signal(7) has a section ("Interruption of system calls and library functions by signal handlers") that talks about EINTR, and execve is not mentioned either.

Anyway, we see it in the wild, and wrapping makes sense.

[giuseppe]

Thanks for the patch! LGTM, could you drop the change to libocispec?

[flouthoc]

@kolyshkin @giuseppe @mrunalp this reverts libocispec to an older version.

[flouthoc]

Although it should not do any harm as far as change seems.

[rhatdan]

LGTM

[kolyshkin]

could you drop the change to libocispec?

Sorry, my bad. Fixed, rebased, pushed.

[giuseppe]

LGTM