Skip to content

utils: retry openat2 on EAGAIN#726

Merged
flouthoc merged 1 commit intocontainers:mainfrom
giuseppe:retry-openat2
Aug 31, 2021
Merged

utils: retry openat2 on EAGAIN#726
flouthoc merged 1 commit intocontainers:mainfrom
giuseppe:retry-openat2

Conversation

@giuseppe
Copy link
Copy Markdown
Member

From the man page:

EAGAIN how.resolve contains either RESOLVE_IN_ROOT or RESOLVE_BENEATH,
and the kernel could not ensure that a ".." component didn't
escape (due to a race condition or potential attack). The caller may
choose to retry the openat2() call.

Closes: #725

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe
Copy link
Copy Markdown
Member Author

test failures are fixed with: #724

I'll rebase once that is merged

@mbaldessari
Copy link
Copy Markdown

LGTM, thanks!

Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From the man page:

EAGAIN how.resolve contains either RESOLVE_IN_ROOT or RESOLVE_BENEATH,
and the kernel could not ensure that a ".." component didn't
escape (due to a race condition or potential attack).  The caller may
choose to retry the openat2() call.

Closes: containers#725

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Copy Markdown
Member Author

rebased. Tests should pass now

@flouthoc flouthoc merged commit 97a6e5c into containers:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: OCI runtime error: openat2 etc/localtime: Resource temporarily unavailable

3 participants