criu: add support for different manage cgroups modes#903
Merged
flouthoc merged 1 commit intocontainers:mainfrom Apr 4, 2022
Merged
criu: add support for different manage cgroups modes#903flouthoc merged 1 commit intocontainers:mainfrom
flouthoc merged 1 commit intocontainers:mainfrom
Conversation
adrianreber
force-pushed
the
2022-04-04-cgroup-ignore
branch
from
fb97114 to
fc043a8
Compare
This is motivated by checkpoint errors of containers restored with a new ID in Podman. Restoring a container with a new name and ID will result in a new cgroup assigned to the container. Unfortunately CRIU restores information about the original cgroup name. Now the container is running in one cgroup but partially has still old cgroup information tied to it. This adds '--manage-cgroups-mode=ignore' to crun which allows crun to tell CRIU to completely ignore anything concerning cgroups. With this change it is possible to checkpoint and restore a container multiple times with changing names and IDs. Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
2022-04-04-cgroup-ignore
branch
from
fc043a8 to
81ccd00
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by checkpoint errors of containers restored with a new ID in Podman.
Restoring a container with a new name and ID will result in a new cgroup assigned to the container. Unfortunately CRIU restores information about the original cgroup name. Now the container is running in one cgroup but partially has still old cgroup information tied to it.
This adds
--manage-cgroups-mode=ignore'to crun which allows crun to tell CRIU to completely ignore anything concerning cgroups.With this change it is possible to checkpoint and restore a container multiple times with changing names and IDs.