WIP: Use the "default" policy section for unidentified images #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
unidentified-images
branch
5 times, most recently
from
7f412ce to
e10db14
Compare
mtrmac
force-pushed
the
unidentified-images
branch
from
e10db14 to
99ebc75
Compare
Without this, processing dir: sources would fail on the reference.ParseNamed immediately below, even with insecureAcceptAnything policy. FIXME: Is this the right thing to do? Allowing local dir: like this might tempt users to use default:insecureAcceptAnything, which would not do. Alternatives: - Hard-code allowing for unidentified images? - Add a new local:, or unidentified: stanza? - Replace default/specific[dockerReference] with an imageType:[somenamespace] (as a single string or object hierarchy?), which would natively support dir: (and allow different semantics for dir:/file/system/path and docker://full-format/reference/with:hostname ) The last one seems best ATM. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
unidentified-images
branch
from
99ebc75 to
b88d71c
Compare
Collaborator
Author
|
Replaced by #33 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder for the discussion in containers/skopeo#97 ; real implementation will be different, I just didn’t want to close that one with nothing to point to.