Finish docker-daemon: #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Now also fixes #72 , making this PR ready for review. |
We now rely on types.Image.UpdatedImage and copy.Image to do the necessary conversions. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This requires renaming the image struct to dockerImage to avoid a naming conflict with containers/image/image . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
docker-daemon
branch
from
1adca02 to
489aff5
Compare
Allow either a !NameOnly named reference, or a sha256:hex digest. Both forms can be used for an ImageSource; ImageDestination accepts only a name:tag value. Because the sha256:hex reference values make it impossible to create a reasonable policy hierarchy, only support a trivial namespace with a single per-transport policy. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…load) This makes the tagging behavior consistent with (docker pull) for projectatomic/docker, and does not change behavior for docker/docker. See the added comment, and containers#72 , for more explanation. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
docker-daemon
branch
from
489aff5 to
49feaef
Compare
runcom
reviewed
Nov 23, 2016
| // Based on github.com/docker/docker/image/image.go | ||
| // MOST CONTENT OMITTED AS UNNECESSARY | ||
| type image struct { | ||
| type dockerImage struct { |
Member
There was a problem hiding this comment.
do we plan to have other *Image types? just image was nice to have. Not a blocker, feel free to skip this comment.
Collaborator
Author
There was a problem hiding this comment.
This is only necessary to make it possible to import containers/image/image, as 29838ec says.
Member
|
lgtm |
Collaborator
Author
|
👍 Thanks! |
This was referenced Nov 23, 2016
giuseppe
pushed a commit
to giuseppe/image
that referenced
this pull request
Jan 24, 2017
Improve manifest digest handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #143 , by deciding on a reference format and implementing it.
Allow either a
!NameOnlynamed reference, or asha256:hex digest. Both forms can be used for anImageSource;ImageDestinationaccepts only a name:tag value.Because the
sha256:hex reference values make it impossible to create a reasonable policy hierarchy, only support a trivial namespace with a single per-transport policy.This does not yet deal with the way projectatomic/docker/reference breaks the normalization (#72).