config: use authPath struct consistently#1765
Merged
rhatdan merged 2 commits intocontainers:mainfrom Dec 20, 2022
Merged
Conversation
cgwalters
force-pushed
the
add-system-path-prep
branch
from
79ea7c2 to
12a3809
Compare
cgwalters
commented
Dec 15, 2022
mtrmac
reviewed
Dec 16, 2022
Collaborator
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
LGTM, just a few possible cleanups to ease future maintenance.
Member
TomSweeneyRedHat
left a comment
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
LGTM
once @mtrmac comments are addressed.
Instead of packing and unpacking it into two variables in various places. Prep for adding a third member of this struct as part of containers#1746 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
add-system-path-prep
branch
from
12a3809 to
a0f60f6
Compare
Just a general cleanup. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
add-system-path-prep
branch
from
a0f60f6 to
7920ffb
Compare
Contributor
Author
|
Thanks, addressed those comments, and also added a further cleanup commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config: use
authPathstruct consistentlyInstead of packing and unpacking it into two variables in
various places. Prep for adding a third member of this struct
as part of #1746
Signed-off-by: Colin Walters walters@verbum.org
config: Make parsing function a method on authFile
Just a general cleanup.