Use trash instead of vndr #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
why? vndr's been in here for what, 2 days?
…On Tue, Feb 28, 2017 at 7:58 AM, Giuseppe Scrivano ***@***.*** > wrote:
it applies on top of: #242 <#242>
------------------------------
You can view, comment on, or merge this pull request online at:
#244
Commit Summary
- Makefile: skip vendor download if not needed
- Makefile: replace vndr with trash
File Changes
- *M* .gitignore
<https://github.com/containers/image/pull/244/files#diff-0> (1)
- *M* .travis.yml
<https://github.com/containers/image/pull/244/files#diff-1> (2)
- *M* Makefile
<https://github.com/containers/image/pull/244/files#diff-2> (27)
Patch Links:
- https://github.com/containers/image/pull/244.patch
- https://github.com/containers/image/pull/244.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#244>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ63F2YrZ0b6upQu0DCDSfhQ5YvVgmks5rhEQOgaJpZM4MOkww>
.
|
Member
Author
|
@erikh more details here: LK4D4/vndr#27 |
Member
|
lgtm |
mtrmac
reviewed
Feb 28, 2017
| @go get $(BUILDFLAGS) github.com/vbatts/git-validation | ||
| @go get -u github.com/LK4D4/vndr | ||
| @go get -u github.com/rancher/trash | ||
| @touch tools.timestamp |
Collaborator
There was a problem hiding this comment.
Hum… use a tools.timestamp: Makefile dependency perhaps so that trash is automatically downloaded after pulling a version of the repo with this PR merged?
Member
Author
There was a problem hiding this comment.
great idea. I've pushed a new version with this change
trash keeps a cache of the repositories, it is faster even in the case vendor.conf is changed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Collaborator
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it applies on top of: #242