Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Jul 4, 2016

Fairly simple PR extracted from #30

@mtrmac you already ack'ed there also. I'll fix skopeo as soon as we merge this.

runcom added 4 commits July 4, 2016 11:29
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
Copy link
Member Author

runcom commented Jul 4, 2016

lgtm

Approved with PullApprove

@mtrmac
Copy link
Collaborator

mtrmac commented Jul 4, 2016

Yes, and as expected, test-skopeo fails. Do you have a corresponding skopeo branch with which it succeeds?

@runcom
Copy link
Member Author

runcom commented Jul 4, 2016

@mtrmac yes I have

@runcom
Copy link
Member Author

runcom commented Jul 4, 2016

@runcom
Copy link
Member Author

runcom commented Jul 4, 2016

skopeo is green with this

@mtrmac
Copy link
Collaborator

mtrmac commented Jul 4, 2016

LGTM, thanks!

Approved with PullApprove

@mtrmac mtrmac merged commit 9d6b8fc into containers:master Jul 4, 2016
@runcom runcom deleted the idioms branch July 4, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants