Hotfix: Do not fetch manifest lists from Docker registries #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows copy.Image to work with Docker Hub registries, which now use manifest lists for many images; the downside is breaking non-copy uses for any non-default architecture. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Collaborator
Author
|
|
Member
will comment it out for now |
Member
|
LGTM |
Collaborator
Author
|
👍 I have marked the test as NOTE: This must not be vendored into projectatomic/docker, see #115 (pulling a manifest list by digest would give us the non-manifest-list manifest, which does not match the digest, and fails). |
This was referenced Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
copy.Imageto work with Docker Hub registries, which now use manifest lists for many images; the downside is breaking non-copyuses for any non-default architecture.