docker,openshift: create http.Client with Timeout #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
lgtm ping @mtrmac |
| httpClient = &http.Client{Transport: transport} | ||
| httpClient.Transport = transport | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
While openshift-copies.go is modified from the originals, I’d prefer not introducing new behavior in there. Could this be moved to openshift.go (which contains the only caller of this function)?
Member
Author
There was a problem hiding this comment.
mm sure, I don't understand what I actually have to move
Collaborator
There was a problem hiding this comment.
- Do not change
openshift-copies.go - In
openshift.go:newOpenshiftClient, set theTimeoutas desired.
Collaborator
|
ACK on the |
runcom
force-pushed
the
refa
branch
2 times, most recently
from
b163a94 to
29d43b7
Compare
Member
Author
|
@mtrmac rebased good to go after your LGTM |
openshift/openshift.go
Outdated
| if *baseURL != *ref.baseURL { | ||
| return nil, fmt.Errorf("Unexpected baseURL mismatch: default %#v, reference %#v", *baseURL, *ref.baseURL) | ||
| } | ||
| http.Client.Timeout = 1 * time.Minute |
Collaborator
There was a problem hiding this comment.
Fails build; s/http.Client/httpClient/?
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Collaborator
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And avoid creating 3 clients in
docker_client.go@mtrmac PTAL
Signed-off-by: Antonio Murdaca runcom@redhat.com