sysregistries: remove trailing slash from registries #428
Conversation
|
@vrothberg looks like you need a merge |
|
@baude PTAL |
|
@vrothberg I think you need to also make a code change at https://github.com/projectatomic/registries as well. |
|
else LGTM |
|
@baude I will look into https://github.com/projectatomic/registries 👍 |
|
@TomSweeneyRedHat @baude I don't see why this change could cause the Travis fail:
|
@vrothberg That’s not a fault of this change, you happened to submit a PR between merging #416 and containers/skopeo#477 . This should disappear after triggering the tests again. |
|
Thanks @mtrmac, it really got me confused 😆 |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
LGTM pending tests (which I have just poked)
|
@runcom PTAL |
|
@mtrmac Tests pass. |
|
LGTM again for pullaprove. Up to @runcom now. |
|
LGTM |
|
needs one last rebase and I'll merge |
It is a common pitfall to add a trailing slash when specifying a registry (e.g., "docker.io/library/" version "docker.io/library"). Remove trailing slashes to normalize the representation of registries. Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
|
@runcom I've rebased the branch. Thanks to all for the feedback and the reviews. |
You're super welcome, thanks for this PR :) |
This is a follow-up change for containers/image#428. It is a common pitfall to add a trailing slash when specifying a registry (e.g., "docker.io/library/" version "docker.io/library"). Remove trailing slashes to normalize the representation of registries. To facilitate testing, don't overwrite the BINARY and MIGRATOR variable when being set in test.bats. Signed-off-by: Valentin Rothberg <vrothberg@suse.com> Closes: #32 Approved by: baude
6 participants
It is a common pitfall to add a trailing slash when specifying a
registry (e.g., "docker.io/library/" version "docker.io/library").
Remove trailing slashes to normalize the representation of registries.
Signed-off-by: Valentin Rothberg vrothberg@suse.com