Use tags when pushing to dockerImageDestination #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
lgtm |
Not pushing to a tag makes the image impossible to pull with a tag. This is not really correct because we keep the Name and Tag in schema1 manifests unmodified, and older registry versions (in particular OpenShift 1.1) do inspect those fields. But, it is better than nothing, and for OpenShift manifest uploads via the Docker API ( containers#95 )a tag is required. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
minimal-docker-push-to-tag
branch
from
8b403f6 to
4157984
Compare
Collaborator
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not pushing to a tag makes the image impossible to pull with a tag.
This is not really correct because we keep the Name and Tag in schema1 manifests unmodified, and older registry versions (in particular OpenShift 1.1) do inspect those fields. But, it is better than nothing,
and for OpenShift manifest uploads via the Docker API ( #95 ) a tag is required.
Recent versions of registry, both docker/distribution and OpenShift, AFAICS completely ignore the tag in schema1 manifests; so that should work fine.