feat: expose *ns keys to consumers#525
Conversation
feat: expose *ns keys to consumers, see: containers#525
inknos
left a comment
inknos
left a comment
There was a problem hiding this comment.
hey, @josegomezr thanks. the PR looks good to me. did you think of any tests to add? I can help you with it if you want to work on it.
also, please sign your commit. that would also retrigger the automation which had a flaky test and it should then pass
|
Hmm, I took the lint suggestions from |
`cgroupns`, `ipcns`, `pidns`, `userns`, `utsns` now support setting the `value` attribute. This allows to mimic the behavior of `--userns`[0] cli arg via this API. [0]: https://docs.podman.io/en/stable/markdown/podman-create.1.html#userns-mode Signed-off-by: Jose D. Gomez R <1josegomezr@gmail.com>
Sorry got late to the party. Where's the suggestion from black? we migrated recently to ruff (which uses their black implementation) so it might be a leftover from the past workflows |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, josegomezr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
cgroupns,ipcns,pidns,userns,utsnsnow support setting thevalueattribute.This allows to mimic the behavior of
--userns0 cli arg via this API.Maybe related to #499
We spotted this missing behavior when using
salt-podman-formula, we realized that setting:Was not bringing the
.container.userns_mode.valueto the actual invocation. The patch allows consumers to send a dict with the options, there's potential to do string parsing (to mimic 1:1 the parsing that the cli does) if desired.