Fix exec_run() returning empty output over SSH connections#644
Open
maxammann wants to merge 1 commit into
Open
Fix exec_run() returning empty output over SSH connections#644maxammann wants to merge 1 commit into
maxammann wants to merge 1 commit into
Conversation
SSHSocket.send()/recv() were writing to subprocess pipes instead of the real forwarded unix socket established by connect(). Additionally, exec_run() now sends Connection: Upgrade headers so the server returns a 101 response, allowing multiplexed output to be read directly from the raw socket. Without the upgrade, http.client closes the connection before the body can be read because no Content-Length or Transfer-Encoding is set. Fixes containers#506 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Max Ammann <max.ammann@zoo.dev>
maxammann
force-pushed
the
fix/exec-run-ssh-empty-output
branch
from
f272447 to
a1ae74d
Compare
Author
|
@jwhonce tyi this should fix podman on macOS as its using SSH connections there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSHSocket.send()/recv() were writing to subprocess pipes instead of the real forwarded unix socket established by connect(). Additionally, exec_run() now sends Connection: Upgrade headers so the server returns a 101 response, allowing multiplexed output to be read directly from the raw socket. Without the upgrade, http.client closes the connection before the body can be read because no Content-Length or Transfer-Encoding is set.
Fixes #506
This debugging was heavily Claude supported. In the end after it figured it out I manually provided the correct and minimal fixes.