remove runlabel test for global opts

[vrothberg]

GLOBAL_OPTS haven't been supported for at least two major versions of
Podman. The runlabel code is extremely fragile and I think it should
be rewritten before adding new features.

Fixes: #12436
Signed-off-by: Valentin Rothberg rothberg@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

@containers/podman-maintainers PTAL

[umohnani8]

LGTM, but tests look unhappy

[edsantiago]

So, I don't know what's so special about OPT1/2/3, but removing that switch statement is causing failures:

# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: generating runlabel install command
# #| expected: '... run -t -i --rm uhMpcyEr5vQPeDRBmzMAY1ylhqRnhN --privileged -v /:/host --net=host --ipc=host --pid=host -e HOST=/host -e NAME=test1 -e IMAGE=localhost/runlabel_image:latest -e CONFDIR=/etc/test1 -e LOGDIR=/var/log/test1 -e DATADIR=/var/lib/test1 localhost/runlabel_image:latest Pzq3hfsYOCVyv2i0CJwFGSaZUf1mGw /bin/install.sh 3jV3wa2J6k13NlDMhgpqNvUQUcJID1'
# #|   actual: '... run -t -i --rm ${OPT1} --privileged -v /:/host --net=host --ipc=host --pid=host -e HOST=/host -e NAME=test1 -e IMAGE=localhost/runlabel_image:latest -e CONFDIR=/etc/test1 -e LOGDIR=/var/log/test1 -e DATADIR=/var/lib/test1 localhost/runlabel_image:latest ${OPT2} /bin/install.sh ${OPT3}'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[vrothberg]

I am going to just remove the test since I am hitting the time limit I set trying to get global opts back. The runlabel code is extremely fragile and I think it should be rewritten before adding new features on top.

[Luap99]

Can you also remove the useless globalOpts variable in the runlabel code?

[Luap99]

LGTM

[vrothberg]

@containers/podman-maintainers PTAL

[mheon]

Do we need to remove the test entirely if the intent is to eventually re-add this?

[rhatdan]

Lets just remove then we can always get them back from git if necessary.
/lgtm

[vrothberg]

Do we need to remove the test entirely if the intent is to eventually re-add this?

I have no intend at the moment but think that the runlabel code should be rewritten at some point. @Luap99 is great with quoting and shell escapes, so it may be something for a cold winter afternoon :^)