Skip to content

bloat-check: always allow on treadmill#18368

Closed
edsantiago wants to merge 1 commit into
containers:mainfrom
edsantiago:bloat_on_treadmill
Closed

bloat-check: always allow on treadmill#18368
edsantiago wants to merge 1 commit into
containers:mainfrom
edsantiago:bloat_on_treadmill

Conversation

@edsantiago
Copy link
Copy Markdown
Member

@edsantiago edsantiago commented Apr 26, 2023

If we fail the bloat check, we can't test for more serious problems.

Signed-off-by: Ed Santiago santiago@redhat.com

None

@edsantiago
bloat-check: always allow on treadmill
258a97d 
If we fail the bloat check, we can't test for more serious
problems.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Apr 27, 2023

Who is looking at the nightly cron job? So far I heard nobody notifying anyone about any problems.

Renovate is now filling updates for these deps daily, I look at PR s see the test failure and fix it if possible or ping the person who can. Point in case (#18350), a regression was caught and fixed in c/common quickly.

So my question why not just remove this nightly job if nobody pays close attention when there is a IMO better solution already in place?

@edsantiago
Copy link
Copy Markdown
Member Author

edsantiago commented Apr 27, 2023

Thanks for the update. I've deleted the treadmill job - it never worked out anyway.

@edsantiago edsantiago closed this Apr 27, 2023
@edsantiago edsantiago deleted the bloat_on_treadmill branch April 27, 2023 11:51
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edsantiago @Luap99