Skip to content

Get masked paths and readonly masked patchs from containers/common @rhatdan#20517

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
rhatdan:mask
Nov 29, 2023
Merged

Get masked paths and readonly masked patchs from containers/common @rhatdan#20517
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
rhatdan:mask

Conversation

@rhatdan
Copy link
Copy Markdown
Member

@rhatdan rhatdan commented Oct 27, 2023

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci Bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2023
@github-actions github-actions Bot added the kind/api-change Change to remote API; merits scrutiny label Oct 27, 2023
Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan force-pushed the mask branch 3 times, most recently from 94bd8f4 to ce4c0ec Compare October 31, 2023 14:15
@TomSweeneyRedHat
Copy link
Copy Markdown
Member

@rhatdan still fighting the red test marks here.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions Bot removed the kind/api-change Change to remote API; merits scrutiny label Nov 19, 2023
@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented Nov 29, 2023

@containers/podman-maintainers PTAL
@Luap99 @vrothberg @umohnani8 @ashley-cui PTAL

@mheon
Copy link
Copy Markdown
Member

mheon commented Nov 29, 2023

LGTM

@mheon
Copy link
Copy Markdown
Member

mheon commented Nov 29, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-merge-bot openshift-merge-bot Bot merged commit 6d9d8f0 into containers:main Nov 29, 2023
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 28, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants