Reenable two skipped tests in run_e2e.go#2328
Reenable two skipped tests in run_e2e.go#2328mheon wants to merge 1 commit intocontainers:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
lgtm |
|
Changes look fine, but looks like a lot of test unhappiness @mheon. |
|
The volume test appears to have been disabled for a reason. It looks like it's not finding a string in /proc/self/mount? |
|
The mount now appears to have the relatime flag, in addition to the expected rw and nodev |
mheon
force-pushed
the
reenable_run_tests
branch
from
56bcf81 to
216159f
Compare
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
mheon
force-pushed
the
reenable_run_tests
branch
from
216159f to
afad7e3
Compare
|
Some instances have nodev, some don't. Not sure why yet. |
|
nodev shows up if you are using the default storage.conf file. |
| host := GetHostDistributionInfo() | ||
| if host.Distribution != "rhel" && host.Distribution != "centos" && host.Distribution != "fedora" { | ||
| Skip("this test requires a working runc") | ||
| } |
There was a problem hiding this comment.
this works only on the Fedora/RHEL package, as we are carrying an extra patch.
upstream doesn't support it yet: opencontainers/runc#1807
There was a problem hiding this comment.
Hm. Fair enough. I'll disable it again and focus on the other tests, which seems to be just changed mount opts.
|
I don't think either of these is getting reenabled easily - we'd need to parse the output of mountinfo more thoroughly to actually determine if mount options are correct. Closing as I don't have time to push it through. |
github-actions
Bot
added
the
locked - please file new issue/PR
6 participants
I have no idea why these were skipped, and when we started skipping them, but let's see if they started passing at some point.
The ubuntu runc one, if it still fails, we can fix ourselves, AFAIK our PPA packages the runc podman uses.