Allow Exec API user to override streams#2487
Merged
openshift-merge-robot merged 1 commit intoFeb 28, 2019
Merged
Conversation
mheon
reviewed
Feb 28, 2019
Member
There was a problem hiding this comment.
If we wanted to be fancy, we could finally implement -i with this... but that sounds like followup work
Collaborator
Author
There was a problem hiding this comment.
Yeah I figured I'd leave the podman exec changes for later :)
mheon
reviewed
Feb 28, 2019
haircommander
force-pushed
the
exec_attahc
branch
from
d7d86c5 to
d7e6864
Compare
rhatdan
reviewed
Feb 28, 2019
Member
|
@baude This might solve your exec problem for health checks. |
Allow passing in of AttachStreams to libpod.Exec() for usage in podman healthcheck. An API caller can now specify different streams for stdout, stderr and stdin, or no streams at all. Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
exec_attahc
branch
from
d7e6864 to
d780e69
Compare
Member
|
Code LGTM |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
|
/lgtm |
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing in of AttachStreams to libpod.Exec() for usage in podman healthcheck. An API caller can now specify different streams for stdout, stderr and stdin, or no streams at all.
Signed-off-by: Peter Hunt pehunt@redhat.com