Skip to content

test/system: do not check dns.podman#25819

Merged
openshift-merge-bot[bot] merged 1 commit into
containers:mainfrom
Luap99:test-dns
Apr 7, 2025
Merged

test/system: do not check dns.podman#25819
openshift-merge-bot[bot] merged 1 commit into
containers:mainfrom
Luap99:test-dns

Conversation

@Luap99
Copy link
Copy Markdown
Member

@Luap99 Luap99 commented Apr 7, 2025

A recent change[1] in netavark makes it so we no longer set the default dns.podman search domain. As such we must no longer test for it.

[1] containers/netavark#1214

Does this PR introduce a user-facing change?

Podman custom networks when using netavark v1.15+ no longer set the default search domain dns.podman. Queries resolving such names will still work. 

A recent change[1] in netavark makes it so we no longer set the default
dns.podman search domain. As such we must no longer test for it.

[1] containers/netavark#1214

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@Luap99
Copy link
Copy Markdown
Member Author

Luap99 commented Apr 7, 2025

@mheon PTAL

@packit-as-a-service
Copy link
Copy Markdown

Cockpit tests failed for commit 254ab3b. @martinpitt, @jelly, @mvollmer please check.

@mheon
Copy link
Copy Markdown
Member

mheon commented Apr 7, 2025

LGTM

@baude
Copy link
Copy Markdown
Member

baude commented Apr 7, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit fe02019 into containers:main Apr 7, 2025
49 of 50 checks passed
@Luap99 Luap99 deleted the test-dns branch April 7, 2025 18:17
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 7, 2025
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Jul 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants