Skip to content

vendor registries.conf rework#28552

Merged
lsm5 merged 2 commits intocontainers:mainfrom
Luap99:registries-conf
Apr 24, 2026
Merged

vendor registries.conf rework#28552
lsm5 merged 2 commits intocontainers:mainfrom
Luap99:registries-conf

Conversation

@Luap99
Copy link
Copy Markdown
Member

@Luap99 Luap99 commented Apr 21, 2026

containers/container-libs#773

Does this PR introduce a user-facing change?

registries.conf loading has been rewritten, see (link to blog post)

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit 7d2a226. @lsm5, @psss, @thrix please check.

@Luap99
Copy link
Copy Markdown
Member Author

Luap99 commented Apr 21, 2026

cockpit tmt tests need cockpit-project/cockpit-podman#2506 I think

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit 54db999. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit aadc523. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit a57a211. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit 02c392f. @lsm5, @psss, @thrix please check.

Luap99 added 2 commits April 23, 2026 16:22
To pull in the registries.conf rework and make sure it all works.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The recent registries.conf rework made so the backend already reads the
env var. As such clients should no longer set it directly to simplify
the code here.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 marked this pull request as ready for review April 23, 2026 14:22
@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit e74582f. @lsm5, @psss, @thrix please check.

@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Apr 23, 2026
@Luap99
Copy link
Copy Markdown
Member Author

Luap99 commented Apr 23, 2026

@containers/podman-maintainers PTAL

Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

Copy link
Copy Markdown
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5 lsm5 merged commit fd57a62 into containers:main Apr 24, 2026
90 of 91 checks passed
@Luap99 Luap99 deleted the registries-conf branch April 24, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants