BATS tests - get working again

[edsantiago]

Various small fixes to get BATS tests working again.
Split from #2947 because that one keeps getting stalled,
and I'm hoping these separate changes get approved.

I consider these changes urgent because RHEL8 gating
tests are failing, and will fail even more if/when #2272
gets picked up and packaged for RHEL8, and I consider
it important to have clean passing tests for RHEL8.

• info test: 'insecure registries' is gone. A recent
  commit (d1a7378) changed the format of 'podman info',
  removing the 'insecure registries' key. Deal with it.

• info test: remove check for .host.{Conmon,OCIRuntime}.package;
  the value on f28 and f29 is 'Unknown' (instead of an NVR).
  We can live without this check.

• 'load' test: skip when running in CI, because stdin
  is not a tty.

• container restore: fix arg processing. Add support to migrate containers #2272 broke argument
  processing: 'podman container restore', with no args, should
  exit with 'argument required' error. Root cause is that the
  new --import option takes the place of an argument, so the
  checkAllAndLatest() call had to be changed to not exit on error.
  Workaround is (sigh) to copy/paste the skipped checkAllAndLatest()
  code, with minor tweaks to accommodate --import.

  *** FIXME FIXME FIXME! If I understand --import correctly,
  *** there should also be a check to prevent positional
  *** arguments with --import. Can someone please confirm/deny?

Signed-off-by: Ed Santiago santiago@redhat.com

[edsantiago]

@adrianreber could you PTAL at the restore.go changes and confirm my understanding of that combination of options? Could you also PTAL at the FIXME comment in my commit message and confirm exactly how podman should behave in that situation? Thank you.

[cevich]

/approve

[jwhonce]

/approve

[mheon]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago, jwhonce, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jwhonce,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

Changes LGTM, though I would like some input from @adrianreber on the --import arg

[jwhonce]

Parenthesis are not required here.

[edsantiago]

Confirmed, fixed, tested. I will force-push the update once I hear back re: --import. Thank you.

[edsantiago]

/hold
pending confirmation of the --import question

[edsantiago]

No response. I'm making a judgment call and disabling use of --import with positional args. New code is a separate commit for ease of reviewing. I also rebased against latest master and verified that tests still pass.
/hold cancel

[mheon]

New changes LGTM

[mheon]

@rhatdan @baude @haircommander @jwhonce PTAL

[haircommander]

/lgtm

[adrianreber]

Sorry, just saw this right now. I was away from a keyboard for a bit more than a week. I see that this is merged, so actually no further comment necessary. It looks correct that --import does not need positional parameters.