libpod removal from main (phase 2)

[baude]

this is phase 2 for the removal of libpod from main.

Signed-off-by: baude bbaude@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

+1

[TomSweeneyRedHat]

Do you have a gomod/vendor issue?

[21:27:22] END - [+0048s] total duration since START
cd ${GOSRC} && ./hack/tree_status.sh |& ${TIMESTAMP}
[21:27:22] START - All [+xxxx] lines that follow are relative to right now.
[+0000s] tree is dirty, please sync the vendor.conf and commit all changes.
[+0000s] 

[TomSweeneyRedHat]

Changes in general LGTM if you can clean up the vendor/lint fun.

[jwhonce]

Assuming vendoring is fixed.

/lgtm
/hold

[baude]

@vrothberg what do i need to do here?

[mheon]

Why is container.go growing log functions? Those either belong in container_api.go or libpod/log.go. Ideally the latter, there are some runtime functions mixed in there.

…

On Wed, Jun 26, 2019, 20:11 Brent Baude ***@***.***> wrote: @vrothberg <https://github.com/vrothberg> what do i need to do here? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3442>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB3AOCAMXT65VQX67H3LNX3P4QAUNANCNFSM4H3WATZA> .

[baude]

Why is container.go growing log functions? Those either belong in container_api.go or libpod/log.go. Ideally the latter, there are some runtime functions mixed in there.

@mheon Im happy to make that change. thanks

[vrothberg]

@vrothberg what do i need to do here?

cd ${GOSRC} && ./hack/tree_status.sh |& ${TIMESTAMP}
[21:27:22] START - All [+xxxx] lines that follow are relative to right now.
[+0000s] tree is dirty, please sync the vendor.conf and commit all changes.
[+0000s] 
[+0000s]  M vendor/modules.txt

./hack/tree_status.sh is just a git status. The important part is M vendor/modules.txt indicating that this file is modified by make vendor but not committed.

You can fix it with make vendor, git add ./vendor/modules.txt and then commit/push.

[vrothberg]

LGTM

[vrothberg]

/hold /lgtm

[vrothberg]

/hold
/lgtm

[baude]

/hold cancel