Implement healthcheck for remote client by ashley-cui · Pull Request #3476 · containers/podman

ashley-cui · 2019-07-02T18:17:12Z

Previously unimplemented. Works the same way the local one does, except its remote.

Signed-off-by: Ashley Cui ashleycui16@gmail.com

mheon · 2019-07-02T18:19:08Z

/approve

openshift-ci-robot · 2019-07-02T18:19:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mheon · 2019-07-02T18:20:21Z

LGTM on my end
@baude @jwhonce PTAL

TomSweeneyRedHat · 2019-07-02T22:05:23Z

s/containter's/container's/ (rogue 't')

TomSweeneyRedHat · 2019-07-02T22:05:36Z

TomSweeneyRedHat · 2019-07-02T22:06:01Z

s/containter/container/

TomSweeneyRedHat · 2019-07-02T22:06:21Z

s/containter/container

rhatdan · 2019-07-03T09:54:28Z

Does this make sense to implement? It seems like a strange use case.

baude · 2019-07-03T13:36:22Z

As much or as little as any other command, imho yes

jwhonce · 2019-07-09T16:35:00Z

LGTM

rh-atomic-bot · 2019-07-15T19:59:40Z

☔ The latest upstream changes (presumably #3574) made this pull request unmergeable. Please resolve the merge conflicts.

vrothberg

LGTM, needs a rebase

rh-atomic-bot · 2019-07-22T20:47:46Z

☔ The latest upstream changes (presumably #3143) made this pull request unmergeable. Please resolve the merge conflicts.

rh-atomic-bot · 2019-08-12T19:10:48Z

☔ The latest upstream changes (presumably #3753) made this pull request unmergeable. Please resolve the merge conflicts.

rhatdan · 2019-08-13T13:42:51Z

@ashley-cui Needs a rebase.

Previously unimplemented. Works the same way the local one does, except its remote. Signed-off-by: Ashley Cui <ashleycui16@gmail.com>

ashley-cui · 2019-08-19T17:35:28Z

@rhatdan tests finally okay. PTAL

rhatdan · 2019-08-19T18:16:25Z

Nice work
/lgtm

openshift-ci-robot requested review from TomSweeneyRedHat and vrothberg July 2, 2019 18:17

openshift-ci-robot added the size/M label Jul 2, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019

ashley-cui force-pushed the remotehealthcheck branch from bed0116 to 15fe82d Compare July 2, 2019 18:31

TomSweeneyRedHat reviewed Jul 2, 2019

View reviewed changes

Comment thread API.md Outdated

Copy link
Copy Markdown

Member

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/containter's/container's/ (rogue 't')

TomSweeneyRedHat reviewed Jul 2, 2019

View reviewed changes

Comment thread API.md Outdated

Copy link
Copy Markdown

Member

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nd/and/

TomSweeneyRedHat reviewed Jul 2, 2019

View reviewed changes

Comment thread cmd/podman/varlink/io.podman.varlink Outdated

Copy link
Copy Markdown

Member

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/containter/container/

TomSweeneyRedHat reviewed Jul 2, 2019

View reviewed changes

Comment thread pkg/varlinkapi/containers.go Outdated

Copy link
Copy Markdown

Member

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/containter/container

ashley-cui force-pushed the remotehealthcheck branch 4 times, most recently from cda815f to 99d4914 Compare July 5, 2019 20:20

mheon added the Release Notes 1.5.0 label Jul 9, 2019

ashley-cui force-pushed the remotehealthcheck branch from 99d4914 to bc5feeb Compare July 9, 2019 17:52

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2019

vrothberg reviewed Jul 22, 2019

View reviewed changes

ashley-cui force-pushed the remotehealthcheck branch from bc5feeb to 5a3638a Compare July 22, 2019 12:57

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2019

ashley-cui force-pushed the remotehealthcheck branch from 5a3638a to fa0ca81 Compare July 23, 2019 12:48

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019

mheon added the Release Notes 1.5.1 label Aug 2, 2019

ashley-cui force-pushed the remotehealthcheck branch from f12e995 to b44083f Compare August 6, 2019 13:25

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2019

ashley-cui force-pushed the remotehealthcheck branch 2 times, most recently from fc484af to 5a3638a Compare August 8, 2019 14:49

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2019

ashley-cui force-pushed the remotehealthcheck branch 2 times, most recently from b049f4c to 2146275 Compare August 8, 2019 20:28

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2019

ashley-cui force-pushed the remotehealthcheck branch from 2146275 to 19d1b06 Compare August 13, 2019 14:15

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2019

mheon added Release Notes 1.5.2 and removed Release Notes 1.5.1 labels Aug 15, 2019

ashley-cui force-pushed the remotehealthcheck branch 2 times, most recently from 7898e05 to 4e0d01b Compare August 19, 2019 14:48

ashley-cui added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2019

Implement healthcheck for remote client

8c7014f

Previously unimplemented. Works the same way the local one does, except its remote. Signed-off-by: Ashley Cui <ashleycui16@gmail.com>

ashley-cui force-pushed the remotehealthcheck branch from 4e0d01b to 8c7014f Compare August 19, 2019 16:16

ashley-cui removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2019

openshift-ci-robot assigned rhatdan Aug 19, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019

openshift-merge-robot merged commit d23639a into containers:master Aug 19, 2019

ashley-cui deleted the remotehealthcheck branch July 17, 2020 13:47

github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023

github-actions Bot locked as resolved and limited conversation to collaborators Sep 24, 2023

Conversation

ashley-cui commented Jul 2, 2019

Uh oh!

mheon commented Jul 2, 2019

Uh oh!

openshift-ci-robot commented Jul 2, 2019

Uh oh!

mheon commented Jul 2, 2019

Uh oh!

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Jul 3, 2019

Uh oh!

baude commented Jul 3, 2019

Uh oh!

jwhonce commented Jul 9, 2019

Uh oh!

rh-atomic-bot commented Jul 15, 2019

Uh oh!

vrothberg left a comment

Choose a reason for hiding this comment

Uh oh!

rh-atomic-bot commented Jul 22, 2019

Uh oh!

rh-atomic-bot commented Aug 12, 2019

Uh oh!

rhatdan commented Aug 13, 2019

Uh oh!

ashley-cui commented Aug 19, 2019

Uh oh!

rhatdan commented Aug 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants