Skip to content

golangci-lint round #3#3562

Merged
openshift-merge-robot merged 1 commit into
containers:masterfrom
baude:golangcilint3
Jul 22, 2019
Merged

golangci-lint round #3#3562
openshift-merge-robot merged 1 commit into
containers:masterfrom
baude:golangcilint3

Conversation

@baude
Copy link
Copy Markdown
Member

@baude baude commented Jul 11, 2019

this is the third round of preparing to use the golangci-lint on our
code base.

Signed-off-by: baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Jul 11, 2019
rhatdan
rhatdan reviewed Jul 11, 2019
View reviewed changes
Comment thread cmd/podman/trust_set_show.go Outdated
Comment thread pkg/apparmor/apparmor_linux.go Outdated
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L labels Jul 12, 2019
jwhonce
jwhonce suggested changes Jul 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jwhonce jwhonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should include the .idea folder. Otherwise, one small nit. LGTM

Comment thread cmd/podman/shared/create.go Outdated
Copy link
Copy Markdown
Member

@jwhonce jwhonce Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the linter accept (time.Duration(1) * time.Second)? I hate to lose the units here.

mheon
mheon reviewed Jul 12, 2019
View reviewed changes
Comment thread .idea/libpod.iml Outdated
@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

rh-atomic-bot commented Jul 18, 2019

☔ The latest upstream changes (presumably #3509) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added size/L and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 18, 2019
@baude baude force-pushed the golangcilint3 branch 2 times, most recently from 0b04a8e to aa0cbef Compare July 18, 2019 23:43
@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

rh-atomic-bot commented Jul 19, 2019

☔ The latest upstream changes (presumably #3590) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2019
@baude baude mentioned this pull request Jul 21, 2019
Closed
@baude
golangci-lint round #3
db826d5 
this is the third round of preparing to use the golangci-lint on our
code base.

Signed-off-by: baude <bbaude@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2019
vrothberg
vrothberg reviewed Jul 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's get this in to avoid merge conflicts. We can sort out the time.Seconds issue mentioned by @jwhonce later.

@rhatdan @jwhonce @mheon @TomSweeneyRedHat PTAL

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3b52e4d into containers:master Jul 22, 2019
This was referenced Jul 22, 2019
Merged
Merged
@baude baude deleted the golangcilint3 branch December 22, 2019 18:52
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rhatdan rhatdan rhatdan left review comments

@mheon mheon mheon left review comments

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

+3 more reviewers

@vrothberg vrothberg vrothberg left review comments

@QiWang19 QiWang19 QiWang19 left review comments

@jwhonce jwhonce jwhonce requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rhatdan rhatdan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@baude @openshift-ci-robot @rh-atomic-bot @rhatdan @jwhonce @mheon @vrothberg @QiWang19 @openshift-merge-robot