Update to the latest version of buildah#5253
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mheon @TomSweeneyRedHat @giuseppe @vrothberg @baude @jwhonce @QiWang19 PTAL |
There was a problem hiding this comment.
Can we include the error in here?
There was a problem hiding this comment.
Did you spin up a 1.14.1 somewhere? The highest release I see is 1.14.0.
There was a problem hiding this comment.
Nope this comes from the master branch. I have no idea where it comes from.
There was a problem hiding this comment.
I think this is being generated by go.mod somehow. The go.mod that I added was from the master branch. We will need to cut a release before podman gets its next release. But this should be fine for now.
$ ./bin/podman info | grep -i buildah
BuildahVersion: 1.15.0-dev
|
My only concern is where Buildah 1.14.1 is coming from, other than that and @mheon's request, LGTM |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@rhatdan thx. I'm fine with that for now, but before we cut Podman.next, I definitely will want to get a new Buildah release together and vendored. |
|
@TomSweeneyRedHat Agreed. We should have @edsantiago add a test to make sure their is never the letters |
|
/lgtm |
Signed-off-by: Daniel J Walsh dwalsh@redhat.com