Skip to content

Update to the latest version of buildah#5253

Merged
openshift-merge-robot merged 1 commit into
containers:masterfrom
rhatdan:buildah
Feb 20, 2020
Merged

Update to the latest version of buildah#5253
openshift-merge-robot merged 1 commit into
containers:masterfrom
rhatdan:buildah

Conversation

@rhatdan
Copy link
Copy Markdown
Member

@rhatdan rhatdan commented Feb 18, 2020

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 18, 2020
@rhatdan rhatdan changed the title [WIP] Update to the latest version of buildah Update to the latest version of buildah Feb 19, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2020
@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented Feb 19, 2020

@mheon @TomSweeneyRedHat @giuseppe @vrothberg @baude @jwhonce @QiWang19 PTAL
Looks like we can update buildah without the containers.conf Merging this should help containers.conf get in. I believe.

Comment thread cmd/podman/build.go Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the error in here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread go.mod Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you spin up a 1.14.1 somewhere? The highest release I see is 1.14.0.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope this comes from the master branch. I have no idea where it comes from.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is being generated by go.mod somehow. The go.mod that I added was from the master branch. We will need to cut a release before podman gets its next release. But this should be fine for now.

$ ./bin/podman info | grep -i buildah
BuildahVersion: 1.15.0-dev

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

My only concern is where Buildah 1.14.1 is coming from, other than that and @mheon's request, LGTM

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@TomSweeneyRedHat
Copy link
Copy Markdown
Member

@rhatdan thx. I'm fine with that for now, but before we cut Podman.next, I definitely will want to get a new Buildah release together and vendored.

@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented Feb 20, 2020

@TomSweeneyRedHat Agreed. We should have @edsantiago add a test to make sure their is never the letters dev in the podman info | grep -i buildah before we release a new podman. Don't want that gating PRs but only releases.

@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented Feb 20, 2020

@mheon @giuseppe @baude @vrothberg @jwhonce @QiWang19 PTAL
Could someone merge this so that we can rebase and see where we are with the greater containers.conf PR.

@giuseppe
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit c8436cd into containers:master Feb 20, 2020
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants