podmanv2 container exists|wait#5571
Merged
Merged
Conversation
baude
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
mheon
reviewed
Mar 20, 2020
Member
|
Is there a way we could get the test suite to run against these. At some point we want to fire up the tests to make sure podman container exists is actually working. |
enable container exists and wait for podmanv2 Signed-off-by: Brent Baude <bbaude@redhat.com>
in the case of exists, use a boolreport structure so that responses can be consistent pointer and error Signed-off-by: Brent Baude <bbaude@redhat.com>
Member
Author
No and then yes, agree. We need enough function to be able to run the test suite first. |
Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jwhonce
reviewed
Mar 20, 2020
enable remote container wait with condition Signed-off-by: Brent Baude <bbaude@redhat.com>
Member
Author
|
updated |
Member
|
/lgtm |
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable container exists and wait for podmanv2
Signed-off-by: Brent Baude bbaude@redhat.com