Skip to content

podmanv2 events#5770

Merged
openshift-merge-robot merged 1 commit into
containers:masterfrom
baude:v2events
Apr 15, 2020
Merged

podmanv2 events#5770
openshift-merge-robot merged 1 commit into
containers:masterfrom
baude:v2events

Conversation

@baude
Copy link
Copy Markdown
Member

@baude baude commented Apr 8, 2020

add the ability to monitor events

Signed-off-by: Brent Baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Apr 9, 2020

LGTM

@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #5634) made this pull request unmergeable. Please resolve the merge conflicts.

@vrothberg
Copy link
Copy Markdown
Member

I am getting the following error on all invocations:

libpod (v2events) $ sudo ./cmd/podmanV2/podmanV2 events
ERRO[0000] failed to read message field: bad message    

V1 does not throw it. I try to have a look but today is filled with meetings until late :/

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020
add the ability to monitor events

Signed-off-by: Brent Baude <bbaude@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2020
@vrothberg
Copy link
Copy Markdown
Member

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@baude
Copy link
Copy Markdown
Member Author

baude commented Apr 15, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9b78bf9 into containers:master Apr 15, 2020
@baude baude deleted the v2events branch May 18, 2022 15:21
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants