Skip to content

Add container subcommands#5799

Closed
baude wants to merge 1 commit into
containers:masterfrom
baude:v2addcontainersub
Closed

Add container subcommands#5799
baude wants to merge 1 commit into
containers:masterfrom
baude:v2addcontainersub

Conversation

@baude
Copy link
Copy Markdown
Member

@baude baude commented Apr 13, 2020

where applicable, add the container commands to the container sub menu

Signed-off-by: Brent Baude bbaude@redhat.com

@baude
Add container subcommands
d794804 
where applicable, add the container commands to the container sub menu

Signed-off-by: Brent Baude <bbaude@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Apr 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Apr 13, 2020

LGTM

TomSweeneyRedHat
TomSweeneyRedHat reviewed Apr 13, 2020
View reviewed changes
Comment thread cmd/podmanV2/containers/unpause.go
})
registry.Commands = append(registry.Commands, registry.CliCommand{
Mode: []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
Command: unpauseCommand,
Copy link
Copy Markdown
Member

@TomSweeneyRedHat TomSweeneyRedHat Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, it would good to switch the order of lines 36 and 37 to match the other commands.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

TomSweeneyRedHat commented Apr 13, 2020

One nit for consideration, otherwise LGTM

vrothberg
vrothberg reviewed Apr 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear we are inconsistent with how we're dealing with commands that are both under main and another sub-command (e.g., image or container). While pull and others create a new cobra.Command with an updated .Example text, we are using the same one here.

I am okay with doing either but want it to be consistent.

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Apr 15, 2020

@jwhonce and @mheon Have already discussed this. I forget the reason.

@rh-atomic-bot
Copy link
Copy Markdown
Collaborator

rh-atomic-bot commented Apr 16, 2020

☔ The latest upstream changes (presumably #5848) made this pull request unmergeable. Please resolve the merge conflicts.

@jwhonce
Copy link
Copy Markdown
Member

jwhonce commented Apr 16, 2020

@baude I prefer separate cobra.Commands where the duplicated fields are copied, and unique fields like Example can be more correct. I like to have the "fully qualified" command be the Parent and alias commands be the child. For example, podman kill pulls from podman container kill. They can live in the same containers.go file.

When the command is a different name, I have been creating new files. For example, images/images.go and images/list.go. Makes finding things much easier.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Apr 17, 2020

@baude: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2020
@baude baude closed this Apr 20, 2020
@baude baude deleted the v2addcontainersub branch May 18, 2022 15:21
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

+1 more reviewer

@vrothberg vrothberg vrothberg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@baude @openshift-ci-robot @rhatdan @TomSweeneyRedHat @rh-atomic-bot @jwhonce @vrothberg