Fix podman-remote images

[rhatdan]

Looks like we went too far with the linters.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@edsantiago PTAL
I think this fixes the podman-remote images.

[rhatdan]

Fixes: #6623

[edsantiago]

Fix confirmed:

$ ./bin/podman-remote --url $MYSOCK images
REPOSITORY                TAG     IMAGE ID      CREATED      SIZE
docker.io/library/alpine  latest  a24bb4013296  2 weeks ago  5.85 MB

[edsantiago]

Gating test failure looks exactly like the one @mheon encountered in his PR

[baude]

lgtm

[mheon]

/lgtm
/hold

[edsantiago]

Test failures: one is a known flake ("streaming something") that has been causing huge problems the past week. Two others are very weird (signal handling), but cirrus-flake-xref knows about them so I'm going to restart them all and hope they go away.

[edsantiago]

CI is passing after many, many test restarts! (the "podman logs" problem being discussed in #6614).

/hold cancel

[edsantiago]

cirrus-flake-analyze:

test ubuntu-19 ubuntu-19

2020-06-16T11:30:48 system_test

• 47 podman kill - test signal handling in containers

2020-06-16T11:35:47 integration_test

• Podman trust [It] podman image trust show
• Podman logs [It] streaming output
• [same]
• [same]

2020-06-16T12:32:30 integration_test

• Podman logs [It] streaming output
• [same]
• [same]
• Podman trust [It] podman image trust show
• Podman rmi [It] podman rmi image that is a parent of another image

test ubuntu-20 ubuntu-20

2020-06-16T11:33:11 system_test

• 47 podman kill - test signal handling in containers

2020-06-16T12:28:57 system_test

• 47 podman kill - test signal handling in containers

2020-06-16T13:13:38 system_test

• 47 podman kill - test signal handling in containers

2020-06-16T14:22:50 system_test

• 47 podman kill - test signal handling in containers