Drop our dependency on github.com/containers/image #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is going to require |
Member
|
LGTM. |
Member
|
LGTM |
Member
|
(FYI @siretart) |
mtrmac
reviewed
Mar 5, 2019
Collaborator
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Sure, this is a reasonable way to do it.
Comments are non-blocking, though do consider at least the BigDataSize API, please.
Remove compatibility hacks for older versions which didn't track size or digest information for big data items, hopefully without any impact. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Drop our dependency on the image library's manifest package by requiring that callers pass its Digest() function to us as a callback. This makes our CLI test/diagnostic tool calculate digests of s1 manifests incorrectly, but that's not something that we were testing. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop our dependency on the image library's manifest package by requiring that callers pass its Digest() function to us as a callback. This makes our CLI test/diagnostic tool calculate digests of s1 manifests incorrectly, but that's not something that we were testing.