Skip to content

vendor: bump mountinfo to v0.3.1#727

Merged
rhatdan merged 2 commits into
containers:masterfrom
kolyshkin:mountinfo-0.3.1
Oct 5, 2020
Merged

vendor: bump mountinfo to v0.3.1#727
rhatdan merged 2 commits into
containers:masterfrom
kolyshkin:mountinfo-0.3.1

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

Unfortunately it contains some breaking changes (in names),
so fix the code accordingly.

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Oct 2, 2020

The PR from dependabot (#729) should be closed in favor of this one (because of breaking changes).

Unfortunately it contains some breaking changes (in names),
so fix the code accordingly.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Copy Markdown
Contributor Author

CI failures seem unrelated

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Oct 2, 2020

@cevich PTAL seems to be something wrong with Ubuntu images in cirrus?

@cevich
Copy link
Copy Markdown
Member

cevich commented Oct 2, 2020

looking...whoa...WTH...I've never seen this before. It's not the images, it's a package that changed and is failing to upgrade during setup for some reason. These kinds of unpredictable failures are exactly why I don't like doing packaging stuffs at testing-time 😢 I think we decided to do it here since it's a low-traffic repo...and so here we are. Sheesh, I'm going to need to dig my heals in and get dirty on this one...and let me guess...all other PRs are having the same problem 😓

I'll put this at the top of my list to poke at on Monday.

@cevich
Copy link
Copy Markdown
Member

cevich commented Oct 2, 2020

Note: if it is a wide-spread packaging problem, waiting and retrying the tests later is also a valid strategy. It's possible that an upstream fix is needed, I dunno yet for sure.

@cevich
Copy link
Copy Markdown
Member

cevich commented Oct 5, 2020

Let me try quick/easy fix of updating images. There are a bunch of shell functions that need to be migrated anyway, to use their new shared versions. Let's see if the errors reproduce in #732

@cevich
Copy link
Copy Markdown
Member

cevich commented Oct 5, 2020

@rhatdan rebasing this once #732 merges will fix the package update failures here. Though this class of automation-problems will persist so long as package update/install is done at testing time. Plopping in freshly built images is a useful workaround (since presumably the new VM images already have many/most recent package updates). Also, FWIW, this process is now much easier than it was before.

@cevich
Copy link
Copy Markdown
Member

cevich commented Oct 5, 2020

/me watching

Copy link
Copy Markdown
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 69ef37b into containers:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants