Skip to content

test/system: Silence some problems pointed out by ShellCheck #1347

Merged
debarshiray merged 2 commits intocontainers:mainfrom
debarshiray:wip/rishi/test-system-shellcheck-silence-00
Aug 12, 2023
Merged

test/system: Silence some problems pointed out by ShellCheck #1347
debarshiray merged 2 commits intocontainers:mainfrom
debarshiray:wip/rishi/test-system-shellcheck-silence-00

Conversation

@debarshiray
Copy link
Copy Markdown
Member

@debarshiray debarshiray commented Aug 11, 2023

No description provided.

@debarshiray
test/system: Silence SC1090
41349f4 
Otherwise https://www.shellcheck.net/ would complain:
  Line 218:
  source <(echo "$output")
         ^---------------^ SC1090 (warning): ShellCheck can't follow
                           non-constant source. Use a directive to
                           specify location.

See: https://www.shellcheck.net/wiki/SC1090

containers#1347
@debarshiray
test/system: Silence SC2004
a055e78 
Otherwise https://www.shellcheck.net/ would complain
  Line 110:
  for ((i = ${num_of_retries}; i > 0; i--)); do
            ^---------------^ SC2004 (style): $/${} is unnecessary on
                              arithmetic variables.

See: https://www.shellcheck.net/wiki/SC2004

containers#1347
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Aug 11, 2023

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/20c75b5b8de9446d97543d3537e55bd4

❌ unit-test NODE_FAILURE Node request 200-0006279613 failed in 0s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 41s
❌ unit-test-restricted RETRY_LIMIT in 33s
❌ system-test-fedora-rawhide NODE_FAILURE Node request 200-0006279822 failed in 0s
❌ system-test-fedora-38 NODE_FAILURE Node request 200-0006279617 failed in 0s
✔️ system-test-fedora-37 SUCCESS in 28m 49s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Aug 11, 2023

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Aug 11, 2023

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/da34833da66f464f897df10b2459bdca

❌ unit-test RETRY_LIMIT in 33s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 35s
❌ unit-test-restricted RETRY_LIMIT in 34s
❌ system-test-fedora-rawhide RETRY_LIMIT in 33s
✔️ system-test-fedora-38 SUCCESS in 30m 04s
✔️ system-test-fedora-37 SUCCESS in 27m 41s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Aug 11, 2023

The tests run on Fedora Rawhide nodes are failing because of the same reasons as in #1344 and #1331 , and the root cause appears to be rsync: https://bugzilla.redhat.com/show_bug.cgi?id=2229654

So, I am going to temporarily ignore these test failures on Fedora Rawhide.

@debarshiray debarshiray force-pushed the wip/rishi/test-system-shellcheck-silence-00 branch from 0b78fb3 to a055e78 Compare August 11, 2023 18:11
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Aug 11, 2023

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/60718b47fa054150b114dfb2a68d853d

❌ unit-test RETRY_LIMIT in 36s
❌ unit-test-migration-path-for-coreos-toolbox TIMED_OUT in 10m 47s
❌ unit-test-restricted RETRY_LIMIT in 35s
❌ system-test-fedora-rawhide RETRY_LIMIT in 37s
✔️ system-test-fedora-38 SUCCESS in 29m 31s
✔️ system-test-fedora-37 SUCCESS in 28m 42s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Aug 12, 2023

I have no idea why unit-test-migration-path-for-coreos-toolbox says TIMED_OUT. It did succeed in #1340 which is rebased on top of this pull request. Let's consider it a flake.

@debarshiray debarshiray merged commit a055e78 into containers:main Aug 12, 2023
@debarshiray debarshiray deleted the wip/rishi/test-system-shellcheck-silence-00 branch August 12, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martymichal martymichal Awaiting requested review from martymichal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@debarshiray